Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piwik 3.2.1 Right Sidebar Menu issue #12334

Closed
dev-101 opened this issue Dec 6, 2017 · 3 comments · Fixed by #12407
Closed

Piwik 3.2.1 Right Sidebar Menu issue #12334

dev-101 opened this issue Dec 6, 2017 · 3 comments · Fixed by #12407
Assignees
@sgiehl
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
Backlog (Help wan...

Comments

@dev-101
Copy link

dev-101 commented Dec 6, 2017 •
edited

Hi, after automated update to 3.2.1 from 3.2.0 right sidebar in Chrome browser (both desktop and mobile) does not show* the usual admin items as before (e.g. in 3.2.0). Clearing browser's cache and/or cookies and signing in again does not help.

Please check screenshots:

3.2.0
piwik 3 2 0 right sidebar

3.2.1
piwik 3 2 1 right sidebar

After checking on desktop, I see that items are still there actually, just not visible until mouse hover (and even then hard to see):

piwik 3 2 1 right sidebar accessibility issue
@sgiehl sgiehl added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Dec 6, 2017
@sgiehl sgiehl added this to the 3.2.2 milestone Dec 6, 2017
@sgiehl
Copy link
Member

sgiehl commented Dec 6, 2017

That seems to be a regression of 80214a8#diff-afe8dd6f32f2190b26e768c6d588d25dR50

@dev-101
Copy link
Author

dev-101 commented Dec 6, 2017

Thanks!
Correct, that change in css overlooked this menu :)

@sgiehl
Copy link
Member

sgiehl commented Dec 6, 2017

Note: When fixing that regression we should add a new screenshot test for those mobile menus to avoid new regressions in the future

@sgiehl sgiehl self-assigned this Jan 6, 2018
@sgiehl sgiehl mentioned this issue Jan 6, 2018
Merged
@GTVolk GTVolk mentioned this issue Jun 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

Successfully merging a pull request may close this issue.

Fix theme color regression matomo-org/matomo
3 participants
@mattab @sgiehl @dev-101