@diosmosis opened this Pull Request on December 4th 2017 Member


  • Changing what piwik.currentDateString is meant to contain. Before it held the date query parameter value, unless the period was a range, in which case it held the last date in the date range (so w/ 2011-01-01,2011-01-23, the date would be 2011-01-23). Now it will contain the two dates for ranges. Note: not sure if this will have any effect on other plugins, but I think core plugins are safe. I noticed it's only used by the managecustomalerts controller.

  • Supply the site's timezone client side for calculating now/today/previousN/lastN. Note: this works for now, but I'm not sure if this is the best way to supply site info to the client.

  • Remove blip when hovering over dates in the date-picker directive.

  • For sanity, handle yesterdaySameTime client side (handled same as yesterday, since the frontend doesn't care about the time of day for periods).
@diosmosis commented on July 16th 2018 Member

@sgiehl will look into it

@diosmosis commented on July 23rd 2018 Member

@sgiehl simplified the code a bit based on your suggestion to look in ScheduledReports, I think it merits another quick review

@sgiehl commented on July 26th 2018 Member

looks good :+1:

This Pull Request was closed on July 26th 2018
Powered by GitHub Issue Mirror