Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several fixes/improvements to angular period selector #12319

Merged
merged 6 commits into from Dec 3, 2017
Merged

Several fixes/improvements to angular period selector #12319

merged 6 commits into from Dec 3, 2017

Conversation

diosmosis
Copy link
Member

Changes:

  • Fix issue where adding invalid value to enabled_periods_UI/enabled_periods_API INI config resulted in a JS object being passed to the period selector instead of array.
  • Use $onInit in period selector of initing code in the directive factory function. Seems AngularJS swallows errors that occur there (note to other devs).
  • Parse previousN/lastN dates correctly in piwikPeriods object.
  • Always try and parse period/date string combo in period selector, since we can't assume range periods have comma separated dates.
  • Angular swallows errors from datepicker.parseDate (because it throws strings), so added a console log for those errors.
  • Display ERROR in period selector if period/date is invalid.

Fixes #12306

@mattab mattab added this to the 3.2.1 milestone Dec 3, 2017
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 3, 2017
@diosmosis
If a period is filtered out, the result of the periods array becomes …
2bb4142 
…an object which breaks the period selector which expects an array.
@diosmosis
Use $onInit instead of directive constructor. Seems angular.js silenc…
70c756c 
…es errors when this is done.
@diosmosis
Parse previousN/lastN dates correctly in angular periods service.
85ee045
@diosmosis
Parse periods using piwikPeriods client side, since we cannot assume …
c9f0b55 
…a date range. Also if an invalid is used for period/date, display ERROR in the period selector.
@diosmosis
Angular will swallow errors from datepicker.parseDate, so add a conso…
bdc9624 
…le.log for developer sanity + make sure period selector has consistent state even when period/date values are invalid (& result in failed date parsing).
@diosmosis
Update misc/log-analytics submodule to latest.
ea87a91
@mattab mattab merged commit 7d35aea into matomo-org:3.x-dev Dec 3, 2017
@diosmosis diosmosis deleted the period-selector-regressions branch December 3, 2017 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @mattab