Added events for adding and filtering profile summaries #12303
Conversation
| * | ||
| * @param ProfileSummaryAbstract[] $profileSummaries An array of profile summaries | ||
| */ | ||
| Piwik::postEvent('Live.addProfileSummaries', array(&$instances)); |
There was a problem hiding this comment.
Not sure if we should introduce an event for adding summaries, as this is done automatically by looking for classes extending the ProfileSummary class.
There was a problem hiding this comment.
It is basically the same as for Visitor Details, Widgets, Reports, ... this way, it allows plugins that define entities, such as custom dimensions, to add for example a profile summary for each entity / custom dimension. It is just a general thing that we do so far as not always it is possible to have it in the plugin structure.
There was a problem hiding this comment.
ah sure. Guess I haven't thought enough before writing the comment...
|
UI test failures seem to be random failures by the looks or not related to this PR: eg https://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/25168/UIIntegrationTest_dashboard2.png |
|
Those failures are related to #12220 I guess |
@sgiehl adding events similar to visitor details events. Will be needed in next release if possible.