Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds segment for device model #12298

Merged
merged 3 commits into from Jan 6, 2018
Merged

Adds segment for device model #12298

merged 3 commits into from Jan 6, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 26, 2017

..and add segmented visitor log link to device model report

refs #7212

@sgiehl sgiehl added the Needs Review PRs that need a code review label Nov 26, 2017
@sgiehl sgiehl added this to the 3.2.2 milestone Dec 4, 2017
@mattab
Copy link
Member

mattab commented Dec 14, 2017

@sgiehl Could you update the tests? Once the segment is tested then it should be good to merge 👍

@sgiehl sgiehl force-pushed the devicemodelsegment branch 2 times, most recently from 3f0c027 to 179ecb3 Compare December 19, 2017 20:43
and segmented visitor log link to device model report
@sgiehl sgiehl merged commit 390edc7 into 3.x-dev Jan 6, 2018
@sgiehl sgiehl deleted the devicemodelsegment branch January 6, 2018 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants