Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show message if visitor log shows no data because the data was purged #12294

Merged
merged 1 commit into from Nov 30, 2017

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 21, 2017

Includes tests.

The message could be adjusted for Super Users vs actual users and then a link added for super users but didn't want to overdo it :)

@tsteur tsteur added the Needs Review PRs that need a code review label Nov 21, 2017
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works as expected. In last build some System test failed. Rebased the branch, if the tests pass this time it should be good to merge 👍

@sgiehl
Copy link
Member

sgiehl commented Nov 22, 2017

Tests passed now 👍

@mattab mattab added this to the 3.2.1 milestone Nov 22, 2017
@mattab mattab merged commit 0309e0b into 3.x-dev Nov 30, 2017
@mattab mattab deleted the visitorlogpurged branch November 30, 2017 01:47
@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Nov 30, 2017
@matomo-org matomo-org deleted a comment from MatomoForumBot Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants