@sgiehl opened this Pull Request on November 15th 2017 Member

Hide widgets when enable_internet_features = 0 is set in config:

  • SEO > SEO rankings
  • About Piwik > Piwik Changelog
  • About Piwik > Piwik.org Blog
  • About Piwik > Latest Marketplace Updates
  • About Piwik > Premium Features

refs #6324

@mattab commented on December 15th 2017 Member

We'd also need to hide the

  • Premium features widget
  • Latest Marketplace Updates widget

  • let's also test most screens in Admin, without internet, to check the feature really works, there are maybe a few remaining things to disable
@sgiehl commented on December 15th 2017 Member

@mattab The two mentioned widgets are now removed as well. Everything else shouldn't be handled in this PR. It's only one step towards solving #6324. It's better to keep pull requests simple and small, so they can be easily merged. So maybe add your other comment in that issue.

@diosmosis commented on March 20th 2018 Member

Would it be possible to use consts for the widget categories/names? If the names change, these new changes might break.

@sgiehl commented on March 22nd 2018 Member

I've updated the PR so it better handles possible name changes of the widgets

@diosmosis commented on March 22nd 2018 Member

@mattab PR looks good, the UI test failures seem unrelated.

This Pull Request was closed on March 22nd 2018
Powered by GitHub Issue Mirror