New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide widgets not working without internet connection if disabled in config #12279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
c: Usability
For issues that let users achieve a defined goal more effectively or efficiently.
Needs Review
PRs that need a code review
labels
Nov 15, 2017
We'd also need to hide the
|
sgiehl
force-pushed
the
seowidgetnointernet
branch
from
December 15, 2017 08:06
b145fed
to
8aeca2d
Compare
sgiehl
force-pushed
the
seowidgetnointernet
branch
from
December 19, 2017 20:48
8aeca2d
to
e4e1dce
Compare
sgiehl
force-pushed
the
seowidgetnointernet
branch
from
January 6, 2018 15:09
e4e1dce
to
79d90aa
Compare
sgiehl
force-pushed
the
seowidgetnointernet
branch
from
January 23, 2018 09:04
79d90aa
to
019cbb8
Compare
sgiehl
force-pushed
the
seowidgetnointernet
branch
2 times, most recently
from
March 11, 2018 21:55
cc87181
to
6c3dda3
Compare
Would it be possible to use |
sgiehl
force-pushed
the
seowidgetnointernet
branch
from
March 22, 2018 20:44
6c3dda3
to
6f18f37
Compare
I've updated the PR so it better handles possible name changes of the widgets |
@mattab PR looks good, the UI test failures seem unrelated. |
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…onfig (matomo-org#12279) * Hide SEO rankings widget if internet is disabled in config * Hide RSS widgets if internet is disabled in config * Remove more wirdgets when internet connection disabled * Adjust widgets to remove after rename to Matomo * Code improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: Usability
For issues that let users achieve a defined goal more effectively or efficiently.
Needs Review
PRs that need a code review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide widgets when
enable_internet_features = 0
is set in config:refs #6324