@iMarkus opened this Pull Request on November 15th 2017 Contributor

Adds First and Last buttons to SiteManager

Maybe this code is not the best way to get all sites count:

function lastPage()
{
    sitesManagerAPI.getSitesIdWithAdminAccess(function (siteIds) {
        if (siteIds && siteIds.length) {
            setCurrentPage(Math.floor(siteIds.length / model.pageSize));
            fetchLimitedSitesWithAdminAccess();
        }
    });
}

grafik

@mattab commented on November 22nd 2017 Member

Thanks for the useful pull request @iMarkus we will review it soon.

@sgiehl commented on March 26th 2018 Member

seems the travis tests aren't triggered anymore for this PR. I'll try closing and reopening...

@sgiehl commented on March 26th 2018 Member

@iMarkus What was the intention of adding the additional offset params? Speeding up the requests as it does not need to query more sites than needed?

@iMarkus commented on March 27th 2018 Contributor

@sgiehl Exactly

@sgiehl commented on July 16th 2018 Member

@iMarkus will you be able to have a look at the comments soon? We would like to integrate this changes in our next release if possible

@tsteur commented on December 19th 2018 Member

@iMarkus not sure if you're still onto this. I presume it might not be needed anymore for you? If you could look at the comments that would be great. Otherwise we might instead just close the PR and create an issue for it so this awesome suggestion doesn't get lost 👍

@iMarkus commented on January 8th 2019 Contributor

@tsteur We can close it and maybe sometime the feature will come :) I am not onto this anymore.

This Pull Request was closed on January 8th 2019
Powered by GitHub Issue Mirror