@iMarkus opened this Pull Request on November 15th 2017 Contributor

Adds First and Last buttons to SiteManager

Maybe this code is not the best way to get all sites count:

function lastPage()
    sitesManagerAPI.getSitesIdWithAdminAccess(function (siteIds) {
        if (siteIds && siteIds.length) {
            setCurrentPage(Math.floor(siteIds.length / model.pageSize));


@mattab commented on November 22nd 2017 Member

Thanks for the useful pull request @iMarkus we will review it soon.

@sgiehl commented on March 26th 2018 Member

seems the travis tests aren't triggered anymore for this PR. I'll try closing and reopening...

@sgiehl commented on March 26th 2018 Member

@iMarkus What was the intention of adding the additional offset params? Speeding up the requests as it does not need to query more sites than needed?

@iMarkus commented on March 27th 2018 Contributor

@sgiehl Exactly

@sgiehl commented on July 16th 2018 Member

@iMarkus will you be able to have a look at the comments soon? We would like to integrate this changes in our next release if possible

Powered by GitHub Issue Mirror