Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase #12269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
requested changes
Nov 12, 2017
| class HttpResponseText extends \PHPUnit_Framework_Constraint | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| class HttpResponseText extends Constraint |
There was a problem hiding this comment.
Tests fail here, as Constraint class can't be found. Guess you need to adjust the use statement
There was a problem hiding this comment.
Thank you, I didn't get this one. I'll amend the commit and change it.
| @@ -86,20 +87,21 @@ public function test_deprecations() | |||
| $this->assertDeprecatedMethodIsRemovedInPiwik4('Piwik\Columns\Dimension', 'getType'); | |||
| } | |||
There was a problem hiding this comment.
could you revert the changes in coding style below?
There was a problem hiding this comment.
Sorry, my IDE did. I revert it. Waiting for Travis CI to check the changes I made.
sgiehl
approved these changes
Nov 13, 2017
|
Should be ready to merge. But we also need to update all the tests in our plugin repos... |
|
@sgiehl I'm going to work on them! |
This was referenced Nov 15, 2017
mattab
modified the milestones:
3.6.0,
Priority Backlog (Help wanted),
Backlog (Help wanted)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use the
PHPUnit\Framework\TestCasenotation instead ofPHPUnit_Framework_TestCasewhile extending our TestCases. This will help us migrate to PHPUnit 6, that no longer support snake case class names.I just to bumped PHPUnit version to
4.8.35, that support thisnamespace.