Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visitor details events #12262

Merged
merged 2 commits into from Nov 9, 2017
Merged

Add visitor details events #12262

merged 2 commits into from Nov 9, 2017

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 9, 2017

Similar to Report.add/filterReports, Widget.add/filterWidgets, etc

We can change naming but kept it consistent with these existing events. It may be a bit confusing to have Live.addVisitorDetails and Live.filterVisitorDetails vs Live.getAllVisitorDetails. For Live.getAllVisitorDetails you would then expect it returns maybe all visitor detail instances. The first 2 work basically on the raw instances, whereas Live.getAllVisitorDetails works on the actual visitor details data. Any thoughts @sgiehl ?

Similar to Report.add/filterReports, Widget.add/filterWidgets, etc

We can change naming but kept it consistent with these existing events. It may be a bit confusing to have `Live.addVisitorDetails` and `Live.filterVisitorDetails` vs `Live.getAllVisitorDetails`. For `Live.getAllVisitorDetails` you would then expect it returns maybe all visitor detail instances. The first 2 work basically on the raw instances, whereas `Live.getAllVisitorDetails` works on the actual visitor details data. Any thoughts @sgiehl ?
@tsteur tsteur added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. labels Nov 9, 2017
@tsteur tsteur added this to the 3.2.1 milestone Nov 9, 2017
@tsteur tsteur merged commit a0545ed into 3.x-dev Nov 9, 2017
@tsteur tsteur deleted the visitordetailsevents branch November 9, 2017 18:26
@matomo-org matomo-org deleted a comment from MatomoForumBot Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants