Make all new segments "Pre-processed" when browser_archiving_disabled_enforce=1 #12254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_enforce=1 If real time processing of segments is disabled via browser_archiving_disabled_enforce=1 then any segment set to "segmented reports are processed in real time (default)" will NEVER be showing data (except in the Live/real time reports) With this PR all new segments will be set to "segmented reports are pre-processed (requires cron)" It does not fix up existing real segments, but existing real time segments would display a modal explaining the issue (refs #12253)
mattab
added
c: Usability
sgiehl
reviewed
Nov 12, 2017
| $isBrowserArchivingDisabled = Config::getInstance()->General['browser_archiving_disabled_enforce']; | ||
|
|
||
| if (!$isBrowserArchivingDisabled) { | ||
| if (!$this->isBrowserArchivingDisabledForSegments()) { |
There was a problem hiding this comment.
Maybe ArchiveProcessor\Rules::isBrowserArchivingAvailableForSegments() could be used instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If real time processing of segments is disabled via browser_archiving_disabled_enforce=1
then any segment set to "segmented reports are processed in real time (default)"
will NEVER be showing data (except in the Live/real time reports)
With this PR all new segments will be set to "segmented reports are pre-processed (requires cron)"
It does not fix up existing real segments, but existing real time segments would display a modal explaining the issue (refs #12253)