Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The modal "Segment '%s' not applied" should display when browser_archiving_disabled_enforce=1 #12253

Closed
mattab opened this issue Nov 7, 2017 · 1 comment
Closed

The modal "Segment '%s' not applied" should display when browser_archiving_disabled_enforce=1 #12253

mattab opened this issue Nov 7, 2017 · 1 comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.

Comments

@mattab
Copy link
Member

mattab commented Nov 7, 2017 •
edited

Regressed the feature introduced in #4569

The following modal should display when the segment is set to "processed in real time" and browser_archiving_disabled_enforce=1

segment not applied

Text reads:

Segment 'has site searched' not applied
You are requesting data for the Custom Segment 'has site searched', this Piwik Enterprise Enterprise configuration currently prevents real time processing of reports for performance reasons.
Your segmented analytics reports will be available later. We apologize for the inconvenience.
Alternatively you may change the setting in the config file (browser_archiving_disabled_enforce), or edit this Segment and choose 'segmented reports are pre-processed (faster, requires cron)'.

I think this was regressed with the new segment editor changes, as now the &segment= parameter is not found in the URL anymore, and the logic displaying this modal currently requires the segment to be in the URL.

Steps

  • Fix the regression (Maybe we should move this logic to JavaScript so we can use the segment value from the #Hash and call an API to know whether the modal should be displayed?)
  • Add a UI test showing the modal so it won't regress in the future
@mattab mattab added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Nov 7, 2017
mattab added a commit that referenced this issue Nov 7, 2017
@mattab
Make all new segments "Pre-processed" when browser_archiving_disabled…
2bfe335 
…_enforce=1

If real time processing of segments is disabled via browser_archiving_disabled_enforce=1
then any segment set to "segmented reports are processed in real time (default)"
will NEVER be showing data (except in the Live/real time reports)

With this PR all new segments will be set to "segmented reports are pre-processed (requires cron)"

It does not fix up existing real segments, but existing real time segments would display a modal explaining the issue (refs #12253)
This was referenced Nov 7, 2017
Merged
Closed
mattab added a commit that referenced this issue Nov 19, 2017
@mattab
Make all new segments "Pre-processed" when browser_archiving_disabled…
89569c9 
…_enforce=1 (#12254)

* Make all new segments "Pre-processed" when browser_archiving_disabled_enforce=1

If real time processing of segments is disabled via browser_archiving_disabled_enforce=1
then any segment set to "segmented reports are processed in real time (default)"
will NEVER be showing data (except in the Live/real time reports)

With this PR all new segments will be set to "segmented reports are pre-processed (requires cron)"

It does not fix up existing real segments, but existing real time segments would display a modal explaining the issue (refs #12253)

* Re-use existing method

* Re-use existing method
@Stan-vw
Copy link
Contributor

Stan-vw commented Aug 28, 2023

Closing because I understand that this modal doesn't exist anymore

@Stan-vw Stan-vw closed this as completed Aug 28, 2023
@michalkleiner michalkleiner added the duplicate For issues that already existed in our issue tracker and were reported previously. label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@michalkleiner @mattab @Stan-vw