Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check XML files in tests for validity #12247

Merged
merged 1 commit into from Nov 19, 2017
Merged

Check XML files in tests for validity #12247

merged 1 commit into from Nov 19, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 2, 2017

Tried locally to revert one of the changes for visitor profile, to have an invalid xml again. Test failed then with:

1) Piwik\Plugins\Live\tests\System\ApiTest::testApi with data set #0 (array('Live.getVisitorProfile'), array(1, '2010-02-01 11:22:33', array('day'), ''))
Response is no valid xml: Specification mandate value for attribute test @1213:15
expected '>' @1219:5
Specification mandate value for attribute test @1220:15
expected '>' @1226:5

fixes #12090

@sgiehl sgiehl added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Nov 2, 2017
@sgiehl sgiehl added this to the 3.2.1 milestone Nov 2, 2017
@sgiehl sgiehl added the Needs Review PRs that need a code review label Nov 2, 2017
@mattab mattab merged commit 113ca89 into 3.x-dev Nov 19, 2017
@matomo-org matomo-org deleted a comment from MatomoForumBot Dec 4, 2017
@mattab mattab deleted the validxml branch December 13, 2017 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: prevent the API returning not well-formed XML
2 participants