New "Event URL" segment `eventUrl` to segment on any Segment URL #12236

mattab · 2017-10-31T03:03:22Z

Useful for many use cases for example:

Creating Custom Reports such as "Top page URLs by Event action"
Segmenting by Event URL and view events triggered on a specific Page URL
Fixes Action URL segment could filter both (Page URLs OR Event URLs) #11131 Action URL segment could filter both Page URLs OR Event URLs (as advertised originally in the 2.16.0 changelog but it wasn't actually fully working yet)

TODO:

Check & fix build

tsteur · 2017-10-31T03:07:01Z

plugins/Events/Columns/EventUrl.php

+{
+    protected $columnName = 'idaction_url';
+    protected $columnType = 'INTEGER(10) UNSIGNED DEFAULT NULL';
+    protected $segmentName = 'EventUrl';


I think this should be eventUrl

tsteur · 2017-10-31T03:07:50Z

plugins/Events/Columns/EventUrl.php

+class EventUrl extends ActionDimension
+{
+    protected $columnName = 'idaction_url';
+    protected $columnType = 'INTEGER(10) UNSIGNED DEFAULT NULL';


columnType needs to be removed otherwise we maybe try to install it again. Might not cause any trouble but ideally this should not be defined twice as we are not sure how system reacts.

tsteur · 2017-11-16T23:15:48Z

I think tests need to be fixed but otherwise 👍

sgiehl · 2017-11-22T22:58:05Z

Last test failing seems to be AutoSuggestAPITest. Could figure out how to fix or why it doesn't suggest any event urls as some events should have been tracked with urls.
@tsteur @mattab any idea on that, otherwise I need to investigate that a bit deeper as soon as I have some more time

mattab · 2017-11-29T08:38:50Z

I noticed the same issue. @sgiehl could you investigate more and see if you can generate test data and how? would be great to merge this one asap

Useful for many use cases for example: * Creating Custom Reports such as "Top page URLs by Event action" * Segmenting by Event URL and view events triggered on a specific Page URL * Fixes #11131 Action URL segment could filter both Page URLs OR Event URLs (as advertised originally in the 2.16.0 changelog but it wasn't actually fully working yet)

…k_visit_action table

sgiehl · 2017-11-29T22:27:35Z

plugins/Live/Visitor.php

@@ -221,6 +221,7 @@ public static function flattenVisitorDetailsArray($visitorDetailsArray)
            $flattenForActionType = array(
                'outlink' => 'outlinkUrl',
                'download' => 'downloadUrl',
+                'event' => 'eventUrl',


this was needed to get suggested values for this segment

sgiehl · 2017-11-29T22:57:38Z

I've now figured out why there weren't any suggest values. But unfortunately there still seems to be a bug in the segment itself. It does not seem to work, as there aren't any matches. Weren't able to get any results in segmented visitor logs. It seems the changes in TableLogActions (https://github.com/piwik/piwik/pull/12236/files#diff-fdad89cc205c1e002ab8f49d1cd3ab76) prevents any results. Not sure yet how to fix it. Guess I need to dig a bit deeper

mattab · 2017-11-30T03:40:36Z

tests/PHPUnit/System/expected/test_AutoSuggestAPITest_eventUrl__VisitsSummary.get_range.xml

@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<result>
+	<nb_visits>0</nb_visits>


we would expect the results to show some visits / actions for this eventUrl ?

mattab

besides the test case not showing data, looks good 👍

sgiehl · 2017-11-30T22:42:33Z

@mattab my last changes should fix it. the eventurl is stored without protocol, so it needs to be removed from suggested values.

mattab · 2017-11-30T23:32:36Z

Looks good @sgiehl

There is only one last failing test in CustomDimensions:

1) Piwik\Plugins\CustomDimensions\tests\System\ApiTest::testApi with data set #24 (array('API.getSegmentsMetadata'), array(1, '2013-01-23 01:23:45', array('year')))

Piwik\Plugins\CustomDimensions\tests\System\ApiTest: Differences with expected in '/home/travis/build/piwik/piwik/plugins/CustomDimensions/tests/System/processed/test___API.getSegmentsMetadata.xml'

Failed asserting that two DOM documents are equal.

--- Expected

+++ Actual

@@ @@

       <row>outlinkUrl</row>

+      <row>eventUrl</row>

@@ @@

     <segment>eventName</segment>

+  </row>

+  <row>

+    <type>dimension</type>

+    <category>Events</category>

+    <name>Event URL</name>

+    <segment>eventUrl</segment>

+    <acceptedValues>The URL must be URL encoded, for example: http%3A%2F%2Fexample.com%2Fpath%2Fpage%3Fquery</acceptedValues>

   </row>

   <row>

     <type>dimension</type>

Could you maybe merge the PR afterwards once tests green?

sgiehl · 2017-11-30T23:44:10Z

That needs to be updated in customdimensions plugin. We can do that after merge as well.

mattab · 2017-12-01T02:42:30Z

Ok will merge now 👍 Thanks for the work on this!

mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Oct 31, 2017

mattab added this to the 3.2.1 milestone Oct 31, 2017

tsteur reviewed Oct 31, 2017

View reviewed changes

mattab added Needs Review PRs that need a code review Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Nov 1, 2017

sgiehl force-pushed the eventUrl branch 3 times, most recently from be17984 to 84b02aa Compare November 21, 2017 21:42

mattab and others added 4 commits November 29, 2017 21:52

fix typo no capital letter

63bdb92

remove column type to prevent new column being created in the log_lin…

4d12eb9

…k_visit_action table

set correct action type for segment eventUrl

39a76a8

sgiehl force-pushed the eventUrl branch from 6d9c95f to 1ab8670 Compare November 29, 2017 20:52

sgiehl added 4 commits November 29, 2017 22:57

modify test

798e543

eventUrl needs action data

fd7c79e

fix suggested values for eventUrl

d90b777

update test files

843c560

sgiehl force-pushed the eventUrl branch from 684ecba to 843c560 Compare November 29, 2017 21:58

sgiehl reviewed Nov 29, 2017

View reviewed changes

mattab commented Nov 30, 2017

View reviewed changes

mattab modified the milestones: 3.2.1, 3.2.2 Nov 30, 2017

sgiehl added 2 commits November 30, 2017 23:33

event url is stored without protocol

952aa8c

update test file

a80bf82

mattab modified the milestones: 3.2.2, 3.2.1 Nov 30, 2017

mattab merged commit 40a8d65 into 3.x-dev Dec 1, 2017

mattab deleted the eventUrl branch December 1, 2017 02:42

matomo-org deleted a comment from MatomoForumBot Dec 4, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New "Event URL" segment `eventUrl` to segment on any Segment URL #12236

New "Event URL" segment `eventUrl` to segment on any Segment URL #12236

mattab commented Oct 31, 2017

tsteur Oct 31, 2017

tsteur Oct 31, 2017 •

edited

tsteur commented Nov 16, 2017

sgiehl commented Nov 22, 2017

mattab commented Nov 29, 2017

sgiehl Nov 29, 2017

sgiehl commented Nov 29, 2017

mattab Nov 30, 2017

mattab left a comment

sgiehl commented Nov 30, 2017

mattab commented Nov 30, 2017

sgiehl commented Nov 30, 2017 via email

mattab commented Dec 1, 2017

New "Event URL" segment eventUrl to segment on any Segment URL #12236

New "Event URL" segment eventUrl to segment on any Segment URL #12236

Conversation

mattab commented Oct 31, 2017

tsteur Oct 31, 2017

Choose a reason for hiding this comment

tsteur Oct 31, 2017 • edited

Choose a reason for hiding this comment

tsteur commented Nov 16, 2017

sgiehl commented Nov 22, 2017

mattab commented Nov 29, 2017

sgiehl Nov 29, 2017

Choose a reason for hiding this comment

sgiehl commented Nov 29, 2017

mattab Nov 30, 2017

Choose a reason for hiding this comment

mattab left a comment

Choose a reason for hiding this comment

sgiehl commented Nov 30, 2017

mattab commented Nov 30, 2017

sgiehl commented Nov 30, 2017 via email

mattab commented Dec 1, 2017

New "Event URL" segment `eventUrl` to segment on any Segment URL #12236

New "Event URL" segment `eventUrl` to segment on any Segment URL #12236

tsteur Oct 31, 2017 •

edited