Add cross domain linking helper text #12235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds a new i18n key CoreAdminHome_JSTracking_CrossDomain_NeedsMultipleDomains
sgiehl
approved these changes
Nov 2, 2017
|
Thanks for the PR @spacenate 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11866
Adds some additional helper text clarifying the need for more than one domain name to exist before cross domain linking can be used.
Adds a new i18n key
CoreAdminHome_JSTracking_CrossDomain_NeedsMultipleDomains.I explored having this additional text only show up if a user has only 1 domain name set up, but this information was not already available in the
Sitedata cache (that I could find), and I did not think it warranted a database request. Let me know if you disagree and would like me to add the behavior I described (only show text if user only has 1 domain set up).🍻