Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent HTML email body for all scheduled reports (HTML, PDF & CSV) #12233

Merged
merged 5 commits into from Nov 24, 2017
Merged

Use consistent HTML email body for all scheduled reports (HTML, PDF & CSV) #12233

merged 5 commits into from Nov 24, 2017

Conversation

diosmosis
Copy link
Member

Fixes #12118

Changes:

  • Extract the creation of the Mail instance from ScheduledReports::sendReport() into new ReportEmailGenerator classes & test.
  • Create View subclasses for html report header/footer and use in ReportRenderer\Html & AttachedReportEmailGenerator.

Screenshots:

(Note: the logo doesn't display since the link is to my local Piwik)

pdf/csv email

pdf-csv-email

html email

html-report-email

@diosmosis diosmosis added the Needs Review PRs that need a code review label Oct 28, 2017
@diosmosis diosmosis added this to the 3.3.0 milestone Oct 28, 2017
@mattab
Copy link
Member

mattab commented Nov 19, 2017

Looks good 👍 except the tests which are failing @diosmosis

@mattab mattab modified the milestones: 3.3.0, 3.2.1 Nov 19, 2017
@sgiehl
Copy link
Member

sgiehl commented Nov 22, 2017

Tests passed now, so guess good to merge now?

@mattab mattab merged commit f092d3b into 3.x-dev Nov 24, 2017
@mattab
Copy link
Member

mattab commented Nov 24, 2017

Well done @diosmosis 👍

@mattab mattab deleted the 12118-pdf-emails branch November 24, 2017 00:58
@matomo-org matomo-org deleted a comment from MatomoForumBot Dec 4, 2017
@mattab mattab added c: Design / UI For issues that impact Matomo's user interface or the design overall. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. labels Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @mattab @sgiehl