@diosmosis opened this Pull Request on October 28th 2017 Member

Fixes #12118


  • Extract the creation of the Mail instance from ScheduledReports::sendReport() into new ReportEmailGenerator classes & test.
  • Create View subclasses for html report header/footer and use in ReportRenderer\Html & AttachedReportEmailGenerator.


(Note: the logo doesn't display since the link is to my local Piwik)

pdf/csv email


html email


@mattab commented on November 19th 2017 Owner

Looks good :+1: except the tests which are failing @diosmosis

@sgiehl commented on November 22nd 2017 Member

Tests passed now, so guess good to merge now?

@mattab commented on November 24th 2017 Owner

Well done @diosmosis :+1:

This Pull Request was closed on November 24th 2017
Powered by GitHub Issue Mirror