Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New setting show_update_notification_to_superusers_only makes it possible to hide update notifications for users except for super users #12224

Merged
merged 6 commits into from Nov 13, 2017

Conversation

peterbo
Copy link
Contributor

@peterbo peterbo commented Oct 24, 2017

fixes #7930

@@ -456,6 +456,10 @@
; the page will automatically refresh every 5 minutes. Set to 0 to disable automatic refresh
multisites_refresh_after_seconds = 300

; by default, update notifications for a new version of Piwik is shown to every user. Set to 1 if only
; the superuser should see the update notification.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description could be improved: Better would be by default, an update notification for a new version of Piwik is shown... or by default, update notifications for new versions of Piwik are shown..., also I guess it would affect all superusers, as there might be more than one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, this was confusing. Changed it a bit - should be more clear to the user now.

@mattab mattab added this to the 3.2.1 milestone Oct 24, 2017
@mattab mattab added the Needs Review PRs that need a code review label Oct 24, 2017
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterbo LGTM, but could you add a note in the CHANGELOG.md about the new config setting?

@sgiehl sgiehl merged commit 4fc3de6 into matomo-org:3.x-dev Nov 13, 2017
@matomo-org matomo-org deleted a comment from MatomoForumBot Dec 4, 2017
@mattab mattab changed the title Show update notification to super users only New config.ini.php setting show_update_notification_to_superusers_only makes it possible to hide update notifications for all users (except super users) Dec 5, 2017
@mattab mattab changed the title New config.ini.php setting show_update_notification_to_superusers_only makes it possible to hide update notifications for all users (except super users) New setting show_update_notification_to_superusers_only makes it possible to hide update notifications for users except for super users Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide update Notification from Users
3 participants