Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use same padding for all widget content #12220

Merged
merged 1 commit into from Nov 22, 2017
Merged

use same padding for all widget content #12220

merged 1 commit into from Nov 22, 2017

Conversation

fdellwing
Copy link
Contributor

this should fix uneven styling in widgets. could not monitor any unwanted differences, but it is possible.

For more infos including a screenshot of status quo see #12175

issue #12175
f0fa69b 
this should fix uneven styling of widgets. could not monitor any unwanted differences, but it is possible.
@Findus23
Copy link
Member

Hi, you can see the result of the UI tests here: https://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/24885/

@fdellwing
Copy link
Contributor Author

Ok, I looked throught the differences and all but one minor change is expected. I see no problem to merge this.

https://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/24885/UIIntegrationTest_dashboard2.png -> Looks good to me.

https://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/24885/UIIntegrationTest_dashboard3.png -> Minor unintented difference (Visitor Map). Should be no problem.

https://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/24885/UIIntegrationTest_dashboard4.png -> Looks good to me.

https://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/24885/Dashboard_reset.png -> Minor unintented difference (Visitor Map). Should be no problem.

https://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/24885/DashboardManager_create_new.png -> Minor unintented difference (Visitor Map). Should be no problem.

@sgiehl sgiehl added the Needs Review PRs that need a code review label Oct 25, 2017
@mattab mattab merged commit 1f12b54 into matomo-org:3.x-dev Nov 22, 2017
@mattab
Copy link
Member

mattab commented Nov 22, 2017

Congrats @fdellwing for your first PR 🎉

@mattab mattab mentioned this pull request Nov 22, 2017
Closed
@mattab mattab changed the title issue #12175 use same padding for all widget content Nov 22, 2017
@mattab mattab added this to the 3.2.1 milestone Nov 22, 2017
@mattab mattab added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Nov 22, 2017
@fdellwing
Copy link
Contributor Author

Thanks 👍

@sgiehl sgiehl mentioned this pull request Nov 27, 2017
Merged
@mattab mattab mentioned this pull request Nov 30, 2017
Merged
@fdellwing fdellwing deleted the fdellwing-#12175 branch November 30, 2017 15:29
@matomo-org matomo-org deleted a comment from MatomoForumBot Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fdellwing @Findus23 @mattab @sgiehl