Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Java detection on Edge as it doesn't work #12214

Merged
merged 1 commit into from Nov 19, 2017
Merged

Ignore Java detection on Edge as it doesn't work #12214

merged 1 commit into from Nov 19, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 20, 2017

navigator.javaEnabled() seems to return always true in Edge browser, even though it doesn't support any plugins. To prevent incorrect detection it should be ignored.

fixes #12117

@sgiehl sgiehl added the Needs Review PRs that need a code review label Oct 20, 2017
@sgiehl sgiehl added this to the 3.2.1 milestone Oct 20, 2017
@mattab mattab merged commit 58428c5 into 3.x-dev Nov 19, 2017
@mattab mattab deleted the edgenojava branch November 19, 2017 21:18
@matomo-org matomo-org deleted a comment from MatomoForumBot Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detecting java plugin on edge browser?
2 participants