Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment for Date::getUtcOffset #12210

Merged
merged 1 commit into from Oct 19, 2017
Merged

Fix comment for Date::getUtcOffset #12210

merged 1 commit into from Oct 19, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 19, 2017

fixes #12205

@sgiehl sgiehl added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Oct 19, 2017
@mattab mattab merged commit 6619f1b into 3.x-dev Oct 19, 2017
@mattab mattab deleted the fixcomment branch December 13, 2017 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Date:getUtcOffset() returns in seconds, not in minutes
3 participants
@sgiehl @tsteur @mattab