Issue the CORS header (Access-Control-Allow-Origin) also on Tracking API requests #12207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
reviewed
Oct 25, 2017
core/Tracker.php
Outdated
| @@ -94,6 +95,10 @@ public function main(Handler $handler, RequestSet $requestSet) | |||
| try { | |||
| $this->init(); | |||
| $handler->init($this, $requestSet); | |||
|
|
|||
| $corsHandler = new CORSHandler(); | |||
There was a problem hiding this comment.
maybe we put this into init? Or before init out of the try/catch as it seems to not throw an exception?
Actually... After a while of thinking it should be done right after Tracker::loadTrackerEnvironment(); in piwik.php I reckon. Since main() might be also used when not being in a web context, and piwik.php makes it actually available to the web so it should be there. This keeps the code cleaner and better re-usable etc. The tracker class and main method is built to be used with different request and this keeps the responsibility to tracking and not to output handling (which is mainly done in piwik.php).
There was a problem hiding this comment.
Absolutely right 👍 made the change
mattab
added
c: Platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up #7626 #5993