Fix addTracker does not return the tracker instance #12203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBD: Need to rebuild js, need to maybe add a test if possible.
tsteur
added
Pull Request WIP
tsteur
commented
Oct 17, 2017
js/piwik.js
Outdated
| @@ -7281,9 +7281,9 @@ if (typeof window.Piwik !== 'object') { | |||
| */ | |||
| addTracker: function (piwikUrl, siteId) { | |||
| if (!asyncTrackers.length) { | |||
| createFirstTracker(piwikUrl, siteId); | |||
| return createFirstTracker(piwikUrl, siteId); | |||
There was a problem hiding this comment.
The doc block already mentioned we return tracker instance, but we did not.
sgiehl
requested changes
Oct 18, 2017
js/piwik.js
Outdated
| } else { | ||
| asyncTrackers[0].addTracker(piwikUrl, siteId); | ||
| return asyncTrackers[0].addTracker(piwikUrl, siteId); | ||
| } |
There was a problem hiding this comment.
JSLint fails here. Guess it needs to be
var tracker;
if (!asyncTrackers.length) {
tracker = createFirstTracker(piwikUrl, siteId);
} else {
tracker = asyncTrackers[0].addTracker(piwikUrl, siteId);
}
return tracker;There was a problem hiding this comment.
thx @sgiehl fixed it, JSLint tests pass now
sgiehl
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBD: