Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable LESS var for header/menu links color #12201

Closed
chrisschauer opened this issue Oct 17, 2017 · 3 comments · Fixed by #12204
Closed

Customizable LESS var for header/menu links color #12201

chrisschauer opened this issue Oct 17, 2017 · 3 comments · Fixed by #12204
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@chrisschauer
Copy link

chrisschauer commented Oct 17, 2017 •
edited

Hi all,

I already dicussed on forum.piwik.org about that: https://forum.piwik.org/t/customize-header-menu-links-color-within-a-theme/23418

I wish to have the oportunately to define the

  • header-background color
  • header-menu color
    within a theme.

But there is only the following:
@theme-color-header-background: #ffffff;

It would be nice to have also e.g. a
@theme-color-menu-text: #ffffff;

Current-version: 3.2.0

Thx
@tsteur
Copy link
Member

tsteur commented Oct 17, 2017

Hi there,

to understand this correctly, you want to change the text color in the header menu? Eg do a dark color because the background is eg white? Only got a little confused because both examples contain background. With menu we reference to the left reporting/admin menu which can be changed with these colors:

@theme-color-menu-contrast-text: @theme-color-text;
@theme-color-menu-contrast-textSelected: @theme-color-menu-contrast-text;
@theme-color-menu-contrast-textActive: @theme-color-brand;
@theme-color-menu-contrast-background: @theme-color-background-contrast;

tsteur added a commit that referenced this issue Oct 18, 2017
@tsteur
fixes #12201 add possibility to change text color in header
4c9d458
@tsteur tsteur mentioned this issue Oct 18, 2017
Merged
@tsteur tsteur added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. labels Oct 18, 2017
@tsteur
Copy link
Member

tsteur commented Oct 18, 2017

FYI: I issued a PR to add @theme-color-header-text

@chrisschauer
Copy link
Author

Hi @tsteur,

sorry for confusing you. You are right - it was a typo on my side. I edited the issue text.
Thanks for the quick response and the PR. It might be useful to add also documentation on: https://developer.piwik.org/guides/theming

Thanks a lot
Chris

mattab pushed a commit that referenced this issue Nov 19, 2017
@tsteur @mattab
Add possibility for themes to change text color in header (#12204)
80214a8 
* fixes #12201 add possibility to change text color in header

* fix screenshot

* fix typo in changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add possibility for themes to change text color in header matomo-org/matomo
2 participants
@tsteur @chrisschauer