Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12143 - Set ngtrim to false to stop automatically trimming input #12197

Merged
merged 1 commit into from Oct 15, 2017
Merged

#12143 - Set ngtrim to false to stop automatically trimming input #12197

merged 1 commit into from Oct 15, 2017

Conversation

Morerice
Copy link
Contributor

@Morerice Morerice commented Oct 15, 2017

Fixes #12143

Happy hacking!

@Findus23
Copy link
Member

Hi,

Many thanks for the fix.
That's somehow an odd default value in my opinion.

Just in case you haven't seen it: We are participating in the Github/Digital Ocean Hacktoberfest.

If you register here https://hacktoberfest.digitalocean.com/ and create three more pull requests in October (on any Github Repository, even though we always appreciate help 😄 ) you'll get a T-Shirt.

@Findus23
Copy link
Member

The failed test (http://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/24801/) don't seem to have anything to do with your change.

@sgiehl sgiehl added this to the 3.2.1 milestone Oct 15, 2017
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 15, 2017
@sgiehl sgiehl merged commit 3a2bc01 into matomo-org:3.x-dev Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants