@sgiehl opened this Pull Request on October 13th 2017 Member

This is kind of a "quick" fix for #11526. But Row Evolution will show the same as when clicking on it in a non "Goal" report. Alternatively we could also simply deactivate Row Evolution for those Goals reports.

Note: I guess it would be awesome to be able to select the goal metrics for row evolution in this case, but that needs a bit more work.

@sgiehl commented on October 18th 2017 Member

I've now updated the implementation. Instead of ignoring possible incorrect idGoal param, I have now renamed the param used to trigger displaying correct goal metrics in goal visualization from idGoal to showGoalMetricsFor. As idGoal is no relevant API parameter for those reports that shouldn't cause any problems.
@tsteur is this solution more suitable?

@tsteur commented on December 15th 2017 Member

I wonder if previous implementation was maybe better as it could break some things. For example when such a report is rendered, in https://github.com/piwik/piwik/pull/12356/files#diff-c337b15b90f57588992ba972d3a21e08R148 I added a check based on the idGoal parameter. Also other plugins may listen to events and do specific things based on the standard idGoal parameter. When fetching the report, this would afterwards maybe no longer work?

@sgiehl commented on December 20th 2017 Member

I'll issue a new PR, that will handle that in rowevolution js. Maybe that's the simplest solution right now.

This Pull Request was closed on December 20th 2017
Powered by GitHub Issue Mirror