Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateCommunication: Use HTTPS links #12186

Closed
wants to merge 13 commits into from
Closed

UpdateCommunication: Use HTTPS links #12186

wants to merge 13 commits into from

Conversation

caugner
Copy link

@caugner caugner commented Oct 13, 2017

Please issue pull request against the 3.x-dev branch only.

Piwik 2 is in LTS mode. This means we do not accept any pull request for 2.x except critical security bugs and major data loss bugs.

If you need to create a pull request for 2.x, then please also create the pull request against the 3.x-dev so we can merge both.

Happy hacking!

@Findus23
Copy link
Member

Hi,
many thanks for your pull request. It's definitly a good idea to send people via HTTPS to help pages.

It seems like my pull request (#12161) already includes this change (https://github.com/piwik/piwik/pull/12161/files#diff-e506a49da888a7c635f900fda8cff67c)

If it is okay for you, I'll fix the tests for it this weekend, so we can merge all changes at once.

@sgiehl
Copy link
Member

sgiehl commented Oct 13, 2017

As @Findus23 mentioned... closing in favor of #12161

@sgiehl sgiehl closed this Oct 13, 2017
@sgiehl sgiehl added the duplicate For issues that already existed in our issue tracker and were reported previously. label Oct 13, 2017
@caugner caugner deleted the patch-1 branch November 25, 2017 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants