Do not show bundles in premium feature widgets #12179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneudert
reviewed
Oct 12, 2017
| @@ -1,6 +1,6 @@ | |||
| <div class="getNewPlugins getPremiumFeatures widgetBody"> | |||
| <div class="row"> | |||
| {% for plugin in plugins %} | |||
| {% for plugin in plugins if not plugin.isBundle %} | |||
There was a problem hiding this comment.
Is there a special case preventing you from using the same array_filter like the plugin listing? Filtering the entries here seems to add an unintuitive extra limit to the already max 20 entries.
There was a problem hiding this comment.
good point, will update PR
mneudert
approved these changes
Oct 13, 2017
There was a problem hiding this comment.
LGTM.
Btw the empty($plugins) check in GetPremiumFeatures.php could also be removed. It probably was not needed for a long time as searchForPlugins should always return an array.
(Tests should of course still work before merging. The current failures however seem unrelated to this specific change)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In "Latest Marketplace Updates" and "Premium Features" widgets which are on the admin home page, do not show bundles as it seems less confusing etc and I think it is not needed to show them there. Better to show individual features.