Formats numbers in the real time widget #12171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @AMcNeice and welcome to our project 👍 we'll review this in the coming days/weeks! |
sgiehl
requested changes
Oct 12, 2017
| <td class="column">{{ visitorsCountToday }}</td> | ||
| <td class="column">{{ pisToday }}</td> | ||
| <td class="column">{{ visitorsCountToday|number }}</td> | ||
| <td class="column">{{ pisToday|number }}</td> |
There was a problem hiding this comment.
Haven't tested your changes yet, but isn't the formatting done twice this way.
The number filter for twig uses this method, which calls NumberFormatter::format, but that is already done in Controller. So guess it should be enough to do it either in Controller or in View.
There was a problem hiding this comment.
@sgiehl - Makes sense, missed the twig formatting referencing that function. I'll test locally and push up some changes that only has the formatting in the view so that all of the items are calling the same helper function.
sgiehl
approved these changes
Oct 17, 2017
|
Thanks for the PR @AMcNeice 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings the formatting of the real time widget inline with the rest of the number formatting.
Addresses issue: #11967