Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of "Goal conversions" may be wrong when applying a segment involving conversions #12158

Open
mattab opened this issue Oct 6, 2017 · 0 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.

Comments

@mattab
Copy link
Member

mattab commented Oct 6, 2017

When applying a user segments involving conversions (such as visit participated in funnel), the number of goal conversions. Here is an example:

No segment applied, numbers are OK.

goal ok

Funnel segment is applied: conversions are multiplied (wrong).

goal not ok

as a result API consumers eg. funnel overview, show the wrong conversions value

goal funnel

Notes

-> maybe the issue is because the archiver does not use necessary group by https://github.com/piwik/piwik/blob/3.2.0-b3/core/DataAccess/LogQueryBuilder.php#L68-L77

it likely doesn't use a subselect, but should use a subselect grouped by CONCAT(log_conversion.idvisit, '_' , log_conversion.idgoal, '_', log_conversion.buster) or so.

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants