Make it possible to show a header message for datatables #12146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Enhancement
tsteur
reviewed
Oct 3, 2017
core/ViewDataTable/Config.php
Outdated
| @@ -363,6 +363,11 @@ class Config | |||
| public $show_ecommerce = false; | |||
|
|
|||
| /** | |||
| * Stores an HTML message (if any) to display above the datatable view. | |||
| */ | |||
| public $show_header_message = false; | |||
There was a problem hiding this comment.
Can we add a little message to show_header_message and show_footer_message that content needs to be escaped properly as both print it raw?
Be also good to have this in developer changelog
sgiehl
force-pushed
the
dtheadermessage
branch
from
abdfeb8
to
81ec6d4
Compare
|
Looks good to merge if tests look alright. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a plugin developer it would be useful to be able to configure a message that should be shown above a datatable. Current configuration only allows to define a message to be shown below in the footer.
As datatables can be quite long (e.g. when chosen to display > 25 entries) the footer message might not visible at first glance.