Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve promo widget #12145

Merged
merged 2 commits into from Oct 3, 2017
Merged

Improve promo widget #12145

merged 2 commits into from Oct 3, 2017

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 3, 2017

Show titles, update icon, make icon clickable, consistent wording.

@tsteur tsteur added the Needs Review PRs that need a code review label Oct 3, 2017
@tsteur tsteur added this to the 3.2.0 milestone Oct 3, 2017
@mattab
Copy link
Member

mattab commented Oct 3, 2017

LGTM

@tsteur
Copy link
Member Author

tsteur commented Oct 3, 2017

FYI: Waiting for tests to finish to fix system and ui tests. will then merge

@tsteur tsteur merged commit 0e6780e into 3.x-dev Oct 3, 2017
@tsteur tsteur deleted the promowidgetupdate branch October 3, 2017 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @mattab