Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backspace eats extra characters #12143

Closed
ghost opened this issue Oct 3, 2017 · 3 comments
Closed

Backspace eats extra characters #12143

ghost opened this issue Oct 3, 2017 · 3 comments
Labels
Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone

Comments

@ghost
Copy link

ghost commented Oct 3, 2017

In several places in Piwik's Web interface, pressing the backspace key will delete two characters instead of one, if by doing so it can delete a space at the end of the input.

Steps to reproduce:

  • Go to "manage" a Goal, either by creating a new one or clicking the edit icon for an existing goal in the "manage" menu.
  • Click at the end of the Description field
  • enter some non-space characters, one space, and then one more non-space character. For example, "abc d"
  • press backspace once. It will delete two characters (the space, and the final non-space character)
  • it ought to delete only one character, leaving the space intact.

I'm running Piwik 3.1.1, server is Linux, Apache, PHP 5.6.31; client is Linux, Pale Moon. It happens to me in every text field in the interface that has fancy fade-in and similar features, throughout the settings and configuration screens, but not in the "search" box and a few other places.

@Findus23
Copy link
Member

Findus23 commented Oct 3, 2017

I can reproduce this in Firefox 56.

I feel like this is kind of intended by some library, but I agree with you that it is annoying as the user doesn't expect it.

@Findus23 Findus23 added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Oct 15, 2017
@Morerice
Copy link
Contributor

Sorry for the first commit which was not branched from 3.x-dev

@sgiehl
Copy link
Member

sgiehl commented Oct 15, 2017

Fixed with #12197

@sgiehl sgiehl closed this as completed Oct 15, 2017
@sgiehl sgiehl added this to the 3.2.1 milestone Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Development

No branches or pull requests

3 participants