Tracking: Write current interaction position for all actions #12125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Just a few system tests failing in https://travis-ci.org/piwik/piwik/jobs/280206776 |
|
should be fixed |
|
still a small fail as the bandwidth fields are expected in the tests output see https://travis-ci.org/piwik/piwik/jobs/280246684 |
|
Updated them again... thought it was green before when I looked... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For events, downloads, ... lets set the
interaction_positionas well instead of having itnull. We set the position to the same position as the last page view. This way we can find out which page was viewed followed by an event.In Piwik 4 we will need to rename
interaction_positionto something likepageview_position#12124 as an event is technically an interaction as well and should increase the counter compared to using the same counter as on the pageview. (refs #9199 )Known issues:
When a user has 2 tabs open, and works on both tabs, the interaction position on any following action will always be set to the interaction position of the last tab.