Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename log_link_visit_action.interaction_position to eg pageview_position #12124

Closed
tsteur opened this issue Sep 26, 2017 · 3 comments · Fixed by #15812
Closed

Rename log_link_visit_action.interaction_position to eg pageview_position #12124

tsteur opened this issue Sep 26, 2017 · 3 comments · Fixed by #15812
Assignees
@sgiehl
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Milestone
4.0.0

Comments

@tsteur
Copy link
Member

tsteur commented Sep 26, 2017

As it is incremented only on pageviews but not eg on events. At the same time we may want to think about adding a new column interaction_position that is also incremented on events etc but not needed for now.
@tsteur tsteur added this to the 4.0.0 milestone Sep 26, 2017
@tsteur tsteur mentioned this issue Sep 26, 2017
Merged
@mattab
Copy link
Member

mattab commented Sep 27, 2017

API

  • should we also rename the interactionPosition in the Live API outputs to pageviewPosition ?

@tsteur
Copy link
Member Author

tsteur commented Sep 27, 2017

yes definitely

@tsteur tsteur added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Feb 11, 2020
@sgiehl sgiehl self-assigned this Apr 14, 2020
This was referenced Apr 14, 2020
Merged
Open
@sgiehl
Copy link
Member

sgiehl commented Apr 15, 2020

@tsteur I've created a follow-up issue where we can implement a new interaction_position column. Feel free to put #15816 in a milestone where we should add it, if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Rename interaction_position to pageview_position matomo-org/matomo
3 participants
@tsteur @mattab @sgiehl