Retry the Live UI tests to avoid random fails #12120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
added
c: Tests & QA
|
Live tests didn't fail here, but other tests. I could invest some time to check that but it could be a waste of time, as there are many tests that sometimes fail even with a retry. Guess there is more important stuff to look at... |
… site search is also currently tested in plugins/Live/tests/UI/expected-ui-screenshots/Live_visitor_log.png
…ow visitor log: done() called multiple times
|
changes may help tiny bit but the original problems remain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently almost all builds fail because of one icon that somehow does not load in the Live/Visitor log UI tests. Maybe this
retrywould help? Let's see what the UI tests say..cc @sgiehl