JS Tracker: Prevent possible infinite loop when page is unloading #12114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
reviewed
Sep 25, 2017
mattab
added
Needs Review
|
@yossicohn please could you update the Pull request so it can get merged? |
|
@tsteur Is that still something we should maybe merge for Matomo 4? Or shall we close this PR? |
|
@sgiehl no big preference, could be useful to have but also quite edge case. |
|
build js |
|
LGTM. Thanks @yossicohn I'm hoping to finally merge this tomorrow. I can't merge it right now as I will need to fix the build afterwards with the minified JS version. |
tsteur
changed the title
mattab
changed the title
mattab
added
the
c: Platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix #12108
Infinite Loop Bug in beforeUnloadHandler()
prevent infinite loop when delta > 3 seconds