No longer show "this is demo.piwik.org" message in top control #12111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
reviewed
Sep 25, 2017
lang/en.json
Outdated
| @@ -432,7 +432,7 @@ | |||
| "YearsDays": "%1$s years %2$s days", | |||
| "Yes": "Yes", | |||
| "YouAreCurrentlyUsing": "You are currently using Piwik %s.", | |||
| "YouAreViewingDemoShortMessage": "You are viewing the demo of Piwik", | |||
| "YouAreViewingDemoShortMessage": "You are viewing the demo of %1$sPiwik%2$s", | |||
There was a problem hiding this comment.
It does not look like the translation key was modified?
There was a problem hiding this comment.
you wrote "I also updated the translation key YouAreViewingDemoShortMessage" but only the string was updated. IIRC you need to change the translation key as well to ensure the string will be re-translated? (although in this case it may work because the translations will miss the %1$s and won't be valid)
There was a problem hiding this comment.
That's what I was wondering whether I have to change it or not. Ideally we would keep the name as it is descriptive but can simply change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing some special code for demo.piwik.org which should not be in core. We will instead add this in a different plugin.
I also updated the translation key
YouAreViewingDemoShortMessagein the hope this will invalidate all existing translations? I don't want to have the whole sentence as a link as it does not look nice and it is not as much noticeable as a link.