Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glossary: make sure to return all metrics and reports #12110

Merged
merged 1 commit into from Sep 27, 2017
Merged

Glossary: make sure to return all metrics and reports #12110

merged 1 commit into from Sep 27, 2017

Conversation

mattab
Copy link
Member

@mattab mattab commented Sep 25, 2017

Add filter_limit=-1 to Request::processRequest calls

@mattab
Glossary: make sure to return all metrics and reports
da0bd78 
Add filter_limit=-1 to Request::processRequest calls
@mattab mattab added the Needs Review PRs that need a code review label Sep 25, 2017
@mattab mattab added this to the 3.1.2 milestone Sep 25, 2017
sgiehl
sgiehl approved these changes Sep 27, 2017
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this will have any effect unless filter_limit=? is in the current request url. But still good to ensure to always show every entry

@sgiehl sgiehl merged commit 52e9403 into 3.x-dev Sep 27, 2017
@sgiehl sgiehl deleted the glossary_all branch September 27, 2017 19:23
@mattab
Copy link
Member Author

mattab commented Sep 27, 2017

I thought it's now needed as the processRequest will set filter_limit to 100 by default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattab @sgiehl