Make sure all users are returned #12109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did not check specifically but would presume getUsers will only return max 100 users here. Ideally we would instead have a method to directly get the number of users count which would be much faster... For some Piwik installations loading this page might take a wee bit longer.
|
Guess in this case it's not relevant if only 100 users are returned or not, as the user count is only used in order to show a warning when switching the theme if there are other users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not check specifically but would presume getUsers will only return max 100 users here. Ideally we would instead have a method to directly get the number of users count which would be much faster... For some Piwik installations loading this page might take a wee bit longer.