@Morerice opened this Pull Request on September 23rd 2017 Contributor

last_seen variable is added to API UsersManager/API::getUsers if it exists.

@tsteur commented on September 24th 2017 Member

I'm a bit worried about performance and wondering if we could rather have a new API for that? We have a couple of usages even within Piwik where we call UsersManager.getUsers. We would ideally test it with eg 30K users (as some Piwik installations do have that many users). The option seems to be autoloaded so it will likely not trigger DB query for each user but still good to check before we regress there

@Morerice commented on September 25th 2017 Contributor

I've updated it according to @sgiehl and @mattab 's requests.

@diosmosis commented on December 6th 2018 Member

This PR may need to be re-worked now. There's a method in UsersManager\API to add last_seen to multiple users: enrichUsersWithLastSeen. Used in a new API method.

@tsteur commented on December 19th 2018 Member

@Morerice if you could look at the last comments and maybe tweak the PR that would be great 👍

Powered by GitHub Issue Mirror