Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call to undefined function Piwik\Plugins\ScheduledReports\mb_strtoupper() in plugins/ScheduledReports/Controller.php 39 #12101

Closed
mattab opened this issue Sep 21, 2017 · 3 comments · Fixed by #12104
Closed

Call to undefined function Piwik\Plugins\ScheduledReports\mb_strtoupper() in plugins/ScheduledReports/Controller.php 39 #12101

mattab opened this issue Sep 21, 2017 · 3 comments · Fixed by #12104
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
Backlog (Help wan...

Comments

@mattab
Copy link
Member

mattab commented Sep 21, 2017

error message reported by email:

Call to undefined function Piwik\Plugins\ScheduledReports\mb_strtoupper() in /home/adad1041/public_html/adept_piwik/plugins/ScheduledReports/Controller.php 39 using PHP 7.0.23

we should call nb_strtotupper only when the function is available (when mbstring extension is enabled), otherwise we should just leave the text as-is (to avoid calling strtotupper on unicode which would not work).
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 21, 2017
@mattab mattab added this to the 3.2.0 milestone Sep 21, 2017
@sgiehl
Copy link
Member

sgiehl commented Sep 22, 2017 •
edited

mbstring extension is required for Piwik. At least we have a system check for it. Also the testMinimumPhpVersion.php should prove that func_overload is disabled. So this method should always be available. But as we already have proxy methods for most mb_* functions, why not adding that one as well...

@sgiehl sgiehl self-assigned this Sep 22, 2017
@sgiehl sgiehl mentioned this issue Sep 22, 2017
Merged
@mattab
Copy link
Member Author

mattab commented Sep 22, 2017

So this method should always be available.

interesting, didn't remember we required the extension. it can become sometimes un-available later if server changes configuration.

@sgiehl
Copy link
Member

sgiehl commented Sep 22, 2017

It's in the list of required extensions in https://github.com/piwik/piwik/blob/3.x-dev/plugins/Diagnostics/Diagnostic/PhpExtensionsCheck.php#L65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

Successfully merging a pull request may close this issue.

Use mbstring proxy methods matomo-org/matomo
2 participants
@mattab @sgiehl