New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2781 Add support for segmentation on Goals.getItems* API #121
#2781 Add support for segmentation on Goals.getItems* API #121
Conversation
Improvements in queryEcommerceItems function which make it works with segments query builder
Thanks for the PR! The tests are failing: https://travis-ci.org/piwik/piwik/jobs/12363492 eg.
Please fix build before I can merge PR. |
Along with the PR here are suggestions for new tests:
Then these tests will generate new XML in processed/* directory. You can check these XML are correct and return only those products that were done by visitors matching the segment. If the XML are valid copy them to the expected/* folder. Then run the tests again, they should pass (or repeat until they pass). Btw the best way to run all tests is in the root of piwik run:
if you want to run specific test:
Note; running takes takes long time. Hope it helps to make a Pull Request including tests If travis is green then the PR should be safe to merge (and we know functionnality will not break in the future, which is an amazing feeling!) |
Conflicts: core/DataAccess/LogAggregator.php plugins/Goals/API.php plugins/Goals/Archiver.php
Looks that tests passed. I've add to EcommerceOrderWithItemsTest acceptance tests with segment parameter and it works. :) |
….getItems Fixes #2781 Add support for segmentation on Goals.getItems* API. Kuddos for the nice pull request and tests!
Improvements in queryEcommerceItems function which make it works with segments query builder and add support for "log_conversion_item" table in segmenetation to join this table with log_visit.