Make old Sparkline Library support PHP 7.2 #12099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
approved these changes
Sep 22, 2017
|
I also don’t have a running php 7.2 system, so I haven’t tested it. Maybe we shouldn’t clone submodules recursively. |
|
Seems travis had some problems or so. I've restarted the builds and now it succeeded. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for #12065 until #12066 is ready to merge.
Refs #11936
Also fixed a typo in the library (but I guess that code isn't executed, otherwise we should have noticed in the last 10 years (since e8700c0))