Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore misc/user/*js files in integrity checker #12091

Merged
merged 1 commit into from Sep 22, 2017
Merged

Ignore misc/user/*js files in integrity checker #12091

merged 1 commit into from Sep 22, 2017

Conversation

mattab
Copy link
Member

@mattab mattab commented Sep 21, 2017

No description provided.

@mattab mattab added this to the 3.1.2 milestone Sep 21, 2017
sgiehl
sgiehl approved these changes Sep 22, 2017
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Any reason for excluding js files in this folder? Wondering if we maybe should ignore all files in this directory and point out in developer docs that this directory is meant to save any user files...

@mattab
Copy link
Member Author

mattab commented Sep 22, 2017

The reason is that in some cases the piwik.js will be generated in the misc/user directory (eg. in the case of InnoCraft cloud)

I prefer to white list files for now (ie. *js and *png) as to make sure we don't over-accept files

@mattab mattab merged commit 3e296e6 into 3.x-dev Sep 22, 2017
@mattab mattab deleted the integrity branch September 22, 2017 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattab @sgiehl