Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor/twig/twig/lib/Twig/Extension/Core.php(1560): Warning - constant(): Couldn't find constant \Piwik::LABEL_ID_GOAL_IS_ECOMMERCE_ORDER #12070

Merged
merged 2 commits into from Sep 20, 2017

Conversation

mattab
Copy link
Member

@mattab mattab commented Sep 17, 2017

Waiting for user feedback whether the notice is fixed

…ension/Core.php(1560): Warning - constant(): Couldn't find constant \Piwik::LABEL_ID_GOAL_IS_ECOMMERCE_ORDER - Piwik 3.1.1-b1 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
@mattab mattab added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Sep 17, 2017
@mattab mattab added this to the 3.1.1 milestone Sep 17, 2017
@robles-design
Copy link

I applied the fix, but it doesn’t work on my installation. Still the same warning:
WARNING: /piwik/vendor/twig/twig/lib/Twig/Extension/Core.php(1560): Warning - constant(): Couldn’t find constant Piwik::LABEL_ID_GOAL_IS_ECOMMERCE_ORDER - Piwik 3.1.1-b2

@mattab
Copy link
Member Author

mattab commented Sep 19, 2017

@robles-design What PHP version do you use?
Is there any chance you could send us (via https://piwik.org/contact/ ) a FTP or SSH access to your Piwik files, so we can try to find a solution for this?

@Findus23
Copy link
Member

@robles-design
Copy link

@mattab I've send you an email via https://piwik.org/contact/
PHP Version 7.1.6-nmm1
Hope this helps.

@teflontoni
Copy link

teflontoni commented Sep 19, 2017

Hey @mattab I've sent you an email as well. (But not via the contact form, but from my business e-mail account). We already had an exchange of e-mails regarding this.
PHP 5.4.16

@robles-design
Copy link

@mattab Did you change something? Seems to work now. I'll test it more intensive tomorrow.

@mattab
Copy link
Member Author

mattab commented Sep 20, 2017

No I didn't change anything yet. Note that the issue only shows up if the Real Time Widgets shows a visit that has converted a Goal

@robles-design
Copy link

Ahh, ok. Thanks for the reply. At this time there aren't any goals, so I produced one and can confirm this.

@mattab
Copy link
Member Author

mattab commented Sep 20, 2017

Hi @robles-design @teflontoni
I still haven't connected to your PIwik or changed anything there, but I think found the issue. Could you please apply this now updated patch? Would be great to hear your feedback!

@robles-design
Copy link

Hi @mattab
I applied the updated patch and it seems to work. I couldn't reproduce the error. I'll give you more feedback after a working day with more traffic on the sites. Thanks for your help!

@mattab
Copy link
Member Author

mattab commented Sep 20, 2017

Great thanks for the quick feedback!

@mattab mattab changed the title Attempt to fix WARNING: /path/to/piwik/vendor/twig/twig/lib/Twig/Extension/Core.php(1560): Warning - constant(): Couldn't find constant \Piwik::LABEL_ID_GOAL_IS_ECOMMERCE_ORDER - Piwik 3.1.1-b1 vendor/twig/twig/lib/Twig/Extension/Core.php(1560): Warning - constant(): Couldn't find constant \Piwik::LABEL_ID_GOAL_IS_ECOMMERCE_ORDER Sep 20, 2017
@mattab mattab merged commit 70537f2 into 3.x-dev Sep 20, 2017
@mattab mattab deleted the notice branch September 20, 2017 03:10
@robles-design
Copy link

Upgraded to 3.1.1 and it works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants