Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend/Refactor file integrity check to take manifest location as a parameter #1207

Closed
robocoder opened this issue Mar 17, 2010 · 6 comments
Closed
Assignees
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@robocoder
Copy link
Contributor

This is to allow for file integrity check of 3rd party plugins downloaded from the plugin repository.

Expands on #1097

Keywords: wishlist

@mattab
Copy link
Member

mattab commented Mar 17, 2010

I don't know if this is required, because plugins would be downloaded from a central repository, and unzipped, which would ensure that all files are correct, wouldn't it?

@robocoder
Copy link
Contributor Author

The website frontend for the repository will also allow plugins to be downloaded manually. In those cases, I anticipate we'll have that segment of users who unzip and ftp the individual files to their server.

@robocoder
Copy link
Contributor Author

While we're at it, add a test to the SecurityInfo plugin to re-run the check.

@mattab
Copy link
Member

mattab commented Mar 20, 2010

Replying to vipsoft:

While we're at it, add a test to the SecurityInfo plugin to re-run the check.
what did you mean by that?

@robocoder
Copy link
Contributor Author

re: comment:5

It means the SecurityInfo plugin could re-run the file integrity check -- i.e., test for core files for tampering.

@mattab
Copy link
Member

mattab commented Apr 15, 2010

If we want to allow for file integrity checks, we need to have all plugins go through our "build script". This could be possible when plugin authors set a SVN path for the build... but if they directly submit their .zip, it will already be built and harder to add the manifest (even though we can always unzip it, add the manifest and zip it back).

I vote for won't fix in V1 of plugin repo, until other more important things are working.

@robocoder robocoder added this to the Official Piwik Plugins Repository project milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

2 participants