We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renderDashboard adds click handlers to #columnPreview divs every time the user visits the dashboard, and never removes them:
renderDashboard
#columnPreview
https://github.com/piwik/piwik/blob/defc5469a5d4634d64023477a447a31c58812a12/plugins/Dashboard/angularjs/dashboard/dashboard.directive.js#L49
The result is a small memory leak.
A quick fix is to add the following just before you add the new listeners:
$('#columnPreview').find('>div').off('click');
If you are concerned about the possibility of there being other click handlers installed on the divs, you can namespace your handlers:
click
$('#columnPreview').find('>div').off('click.renderDashboard'); $('#columnPreview').find('>div').on('click.renderDashboard', ...);
The text was updated successfully, but these errors were encountered:
sgiehl
Successfully merging a pull request may close this issue.
renderDashboard
adds click handlers to#columnPreview
divs every time the user visits the dashboard, and never removes them:https://github.com/piwik/piwik/blob/defc5469a5d4634d64023477a447a31c58812a12/plugins/Dashboard/angularjs/dashboard/dashboard.directive.js#L49
The result is a small memory leak.
Solution
A quick fix is to add the following just before you add the new listeners:
If you are concerned about the possibility of there being other
click
handlers installed on the divs, you can namespace your handlers:The text was updated successfully, but these errors were encountered: