Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression for Plugins extending EventAction class #12041

Closed
Yiivgeny opened this issue Sep 12, 2017 · 1 comment · Fixed by #12048
Closed

regression for Plugins extending EventAction class #12041

Yiivgeny opened this issue Sep 12, 2017 · 1 comment · Fixed by #12048
Assignees
@sgiehl

Comments

@Yiivgeny
Copy link

Yiivgeny commented Sep 12, 2017 •
edited

1d5bbb5#commitcomment-24263189

My class ovverride EventAction class and getEventCategory method for internal recording additional events for some page views. But commit #1d5bbb5 crash my logic as not use suitable method and read data from raw request data (which does not exist for manually created EventAction).
@sgiehl
Copy link
Member

sgiehl commented Sep 13, 2017

Thanks for the note. I'll prepare a PR to change that in next version

@sgiehl sgiehl self-assigned this Sep 13, 2017
@sgiehl sgiehl mentioned this issue Sep 13, 2017
Merged
Yiivgeny referenced this issue Sep 18, 2017
@sgiehl
Disallow event tracking with empty/whitespace categories (#11819)
1d5bbb5 
* trim event values before checking if they are empty

* Prevent possible archiving failures for already tracked empty event categories

* Throw exception when tracking events with empty category or action

* move trim method

* Log console error when tracking events without category or action

* rebuilt piwik.js
@mattab mattab changed the title Crash manually created EventAction with 3.1.0 update regression for Plugins extending EventAction class Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reuse event action methods in event columns matomo-org/matomo
2 participants
@Yiivgeny @sgiehl