New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better segment editor and fixes #12040
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er and it uses an inner query
…omatically for columns with enums
tsteur
added
Needs Review
PRs that need a code review
Enhancement
For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
labels
Sep 13, 2017
Merging now as discussed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Needs Review
PRs that need a code review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<div piwik-segment-generator>
actionServerHour
,actionServerMinute
,visitStartServerHour
,visitStartServerMinute
,visitEndServerMinute
,visitLocalMinute
protected $segmentName = 'myConversionSegmentName';
.... optionally it is possible to specify a sql segmentprotected $sqlSegment = 'MINUTE(log_link_visit_action.server_time)';
andprotected $acceptValues = '0, 1, 2, 3, ..., 56, 57, 58, 59';
log_action.type=1
then it is a page urlsuggestedValuesCallback
for segments, forsqlFilter
, and other things.Re developer changelog: There is no breaking API change but we have new ways to define a segment. Can add this to the docs or we do it with Piwik 4.
Related PRs:
In this PR I assumed the next version will be Piwik 3.2.0. If we choose to make it 3.1.1 let's rename all mentions of 3.2.0