Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render only known action types #12038

Merged
merged 1 commit into from Sep 13, 2017
Merged

Render only known action types #12038

merged 1 commit into from Sep 13, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Sep 12, 2017

With the refactoring of visitor details new action types can be included (for example content actions).
As the real time widget hasn't been adjusted, such actions might result in an error as they are tried to be rendered as a goal/ecommerce action.
This change will exclude those action from being rendered for now. We can later adjust the widget to also render custom actions.

refs #12033
fixes #12037

@sgiehl sgiehl added Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Sep 12, 2017
@sgiehl sgiehl added this to the 3.2.0 milestone Sep 12, 2017
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 12, 2017
@sgiehl sgiehl merged commit 663ea20 into 3.x-dev Sep 13, 2017
@sgiehl sgiehl deleted the realtimeactions branch September 13, 2017 14:13
@mattab mattab modified the milestones: 3.2.0, 3.1.1 Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal on real time widget, icon not defined
2 participants